Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] - Fix VPN crashing if you purchase Leo AFTER VPN. #26528

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Brandon-T
Copy link
Contributor

Resolves brave/brave-browser#42268

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 13, 2024
@Brandon-T Brandon-T self-assigned this Nov 13, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner November 13, 2024 15:10
@Brandon-T Brandon-T merged commit 9cecaa8 into master Nov 14, 2024
18 checks passed
@Brandon-T Brandon-T deleted the bugfix/VPNCrash branch November 14, 2024 22:45
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 14, 2024
brave-builds added a commit that referenced this pull request Nov 14, 2024
brave-builds added a commit that referenced this pull request Nov 14, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.21

@hffvld
Copy link
Collaborator

hffvld commented Nov 15, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.75 (23)
BraveCore: 1.75.23 (131.0.6778.69)

STEPS:

  1. Launch Brave
  2. Purchase VPN
  3. Purchase Leo
  4. Hamburger menu > Settings
  5. Brave Firewall + VPN > Verify

ACTUAL RESULTS:

  • Verified that Brave does not crash when accessing the VPN settings screen if VPN and Leo subscriptions are purchased.
  • Verified that able to connect to different VPN servers.

1 2 3 4
1 2 3 4
2024-11-15_14-47-53.mp4

kjozwiak pushed a commit that referenced this pull request Nov 15, 2024
kjozwiak pushed a commit that referenced this pull request Nov 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - BraveVPN crashes if purchasing Leo AFTER VPN
4 participants