Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Small text change to Leo opt-in copy #43413

Closed
1 of 6 tasks
mattmcalister opened this issue Jan 22, 2025 · 2 comments · Fixed by brave/brave-core#27305
Closed
1 of 6 tasks

Small text change to Leo opt-in copy #43413

mattmcalister opened this issue Jan 22, 2025 · 2 comments · Fixed by brave/brave-core#27305
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone

Comments

@mattmcalister
Copy link

Description

The current Leo opt-in modal refers to the Mixtral model, but we are changing the default. We should update the language to be more abstract.

Steps to reproduce

  1. New profile
  2. Open Leo panel
  3. Begin a conversation
  4. See consent language

Actual result

Image

Expected result

This issue proposes to change the text to "The default model will change from time to time." It also updates the Help Center link from the Leo section home to the specific article on LLMs: What are the differences between Leo's AI Models? https://support.brave.com/hc/en-us/articles/26727364100493-What-are-the-differences-between-Leo-s-AI-Models

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.76.24 Chromium: 132.0.6834.83 (Official Build) nightly (arm64)

Android device

  • Brand/model:
  • Android version:

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Policy review for this change: https://github.com/brave/reviews/issues/1830 (closed)

@mattmcalister mattmcalister added browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jan 22, 2025
@mattmcalister mattmcalister self-assigned this Jan 22, 2025
mattmcalister added a commit to brave/brave-core that referenced this issue Jan 22, 2025
Abstracts the name of the model and updates the link to the relevant Help Center doc

Resolves brave/brave-browser#43413
@mattmcalister mattmcalister moved this to In Progress in Browser AI Jan 22, 2025
@mattmcalister mattmcalister moved this from In Progress to In Review in Browser AI Jan 22, 2025
bsclifton pushed a commit to brave/brave-core that referenced this issue Jan 23, 2025
Abstracts the name of the model and updates the link to the relevant Help Center doc

Resolves brave/brave-browser#43413
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Jan 23, 2025
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 23, 2025
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 7, 2025
@hffvld
Copy link
Contributor

hffvld commented Feb 7, 2025

Verified on Pixel 6 using version(s):

Device/OS: Pixel 6 / oriole-user 15 AP4A.241205.013 release-keys
Brave build: 1.76.52 
Chromium: 133.0.6943.54 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the STR/TP from Small text change to Leo opt-in copy #43413 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that The default model for all users is currently Mixtral 8x7B. string was updated to The default model will change from time to time.
  • Verified that Brave wiki was updated to Brave Help Center URL.

Old strings/URL Updated strings/URL
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 7, 2025
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 14, 2025

Verification PASSED using

Brave | 1.76.58 Chromium: 133.0.6943.98 (Official Build) beta (64-bit)
-- | --
Revision | e6c9f3240b1045e0f4bcb1301b9a0d7cda5684f8
OS | Windows 11 Version 24H2 (Build 26100.2894)
  1. Installed 1.76.58
  2. launched Brave
  3. clicked on Leo icon to open Leo panel
  4. entered "BAT" in the input field
  5. consent page shown as expected
1.75.x 1.76.x
Image Image
Image Image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants