Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates learn more links in Leo consent and tooltips #27305

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

mattmcalister
Copy link
Collaborator

@mattmcalister mattmcalister commented Jan 22, 2025

Resolves brave/brave-browser#43413
Resolves brave/brave-browser#38171

Reviewed https://github.com/brave/reviews/issues/1830

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mattmcalister mattmcalister requested a review from a team as a code owner January 22, 2025 13:27
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 22, 2025
@mattmcalister mattmcalister changed the title Browser ai/learn more links Updates learn more links in Leo consent and tooltips Jan 22, 2025
@mattmcalister mattmcalister requested a review from bbondy January 22, 2025 13:29
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄👍

Abstracts the name of the model and updates the link to the relevant Help Center doc

Resolves brave/brave-browser#43413
The help card for each model includes a link to 'Learn more'. The link was missing on the Anthropic models.

Resolves brave/brave-browser#38171
@bsclifton bsclifton force-pushed the browser-ai/learn-more-links branch from 1434fcb to b6bf39f Compare January 23, 2025 05:14
@bsclifton
Copy link
Member

bsclifton commented Jan 23, 2025

Just rebased and with my setup that did the commit signing (which is required). Going to mark as Auto-merge - should merge once CI finishes

@bsclifton bsclifton enabled auto-merge January 23, 2025 05:14
@bsclifton bsclifton merged commit 73372a9 into master Jan 23, 2025
18 checks passed
@bsclifton bsclifton deleted the browser-ai/learn-more-links branch January 23, 2025 07:08
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 23, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.34

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants