Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Links in brave://getting-started don't open properly #43719

Closed
1 of 6 tasks
bsclifton opened this issue Feb 4, 2025 · 2 comments · Fixed by brave/brave-core#27497
Closed
1 of 6 tasks

Links in brave://getting-started don't open properly #43719

bsclifton opened this issue Feb 4, 2025 · 2 comments · Fixed by brave/brave-core#27497
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 4, 2025

Test plan

See brave/brave-core#27497

Description

New users will have brave://getting-started opened after they finish the welcome experience

In here, there are some links which folks can click

  1. Image
  2. Image

Clicking either of these will cause an error which you can see in the JavaScript console:

Blocked opening 'https://brave.com/whats-new/' in a new window because the request was made in a sandboxed frame whose 'allow-popups' permission is not set.

Steps to reproduce

  1. Open brave://getting-started
  2. Find the See a better web or Learn more buttons (see picture above for context)
  3. Click the button

Actual result

JavaScript errors are thrown

Expected result

The link should open

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave		1.77.10 Chromium: 133.0.6943.39 (Official Build) nightly (64-bit) 
Revision	2f0a7f93d99c180ce71ddde77743ab6652afd8b5
OS		Windows 11 Version 24H2 (Build 26100.2894)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.76.57 or higher for 1.76.x verification 👍 Can be verified alongside #40157 (comment).

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 14, 2025
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 14, 2025

Verification PASSED on

Brave | 1.76.59 Chromium: 133.0.6943.98 (Official Build) beta (64-bit)
-- | --
Revision | 334a148956fff51a37bb1658728012f209e0e2a8
OS | Windows 10 Version 22H2 (Build 19045.5487)
  • Verified the STR from the description and ensured that click on See a better web or Learn more buttons on brave://getting-started/ page redirects to intended pages
  • Verified the other links like Open Brave wallet, Chat with Leo, Open Brave Rewards and Open Firewall + VPN and ensured that the links are redirected to intended pages/panel
See a better web Learn more
Image Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants