Skip to content

Commit

Permalink
Allow popups from inside brave://getting-started iframe (#27497)
Browse files Browse the repository at this point in the history
* Allow popups from inside brave://getting-started iframe

Fixes brave/brave-browser#43719

* Added attribute per discussion in security review
  • Loading branch information
bsclifton authored Feb 5, 2025
1 parent 864519d commit 63bde3c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {BraveEducationAppElement} from './brave_education_app.js';
export function getHtml(this: BraveEducationAppElement) {
return this.url_ ?
html`<iframe id="content" src="${
this.url_}" sandbox="allow-scripts allow-same-origin"></iframe>` :
this.url_}" sandbox="allow-scripts allow-same-origin allow-popups
allow-popups-to-escape-sandbox"></iframe>` :
'';
}

0 comments on commit 63bde3c

Please # to comment.