Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Choose Device Type modal is not shown after going offline and back online #7854

Closed
btlechowski opened this issue Jan 21, 2020 · 3 comments
Closed
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/sync fixed-with-sync-v2 QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

btlechowski commented Jan 21, 2020

Found when testing new sync UI changes #6941.

Steps to Reproduce

  1. Open brave://sync
  2. Go offline
  3. Click Start a new Sync Chain
  4. Wait a minute
  5. Go online
  6. Wait till Choose Device Type modal is shown

IMPORTANT: after page reload, the modal is shown

Actual result:

Choose Device Type modal is not shown
The UI is stuck on sync creation
image

Expected result:

Choose Device Type modal is shown
image

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.5.46 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @cezaraugusto @AlexeyBarabash @jsecretan

@cezaraugusto
Copy link
Contributor

@AlexeyBarabash do you think we can intercept offline requests in the back-end? Doing this with JavaScript is not reliable since there's no native listener in WebAPIs for offline events.

@AlexeyBarabash
Copy link
Contributor

@cezaraugusto I agree, doing this with javascript in UI is not an option.
I think we have the error event for such case but I need to check why it isn't passed to UI.

@AlexeyBarabash
Copy link
Contributor

This is not applicable now, because with Sync v2 when we press Start a new Sync Chain - then the passphase is generated but there is no any communication with the server, so offline/online doesn't have any effect on this.

And even I would do:

  1. go offline
  2. create sync chain
  3. go online
  • then the chain gets created.

So I am closing this issue.

@AlexeyBarabash AlexeyBarabash added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. fixed-with-sync-v2 labels Jan 9, 2023
@rebron rebron moved this to Completed in Sync - All platforms Jul 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/sync fixed-with-sync-v2 QA/Test-Plan-Specified QA/Yes
Projects
Status: Completed
Development

No branches or pull requests

6 participants