-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Modify Sync UI to allow only one device in chain #4239
Conversation
2cfb52e
to
403f0fd
Compare
@darkdh @AlexeyBarabash this PR is ready for review |
Previous message is wrong because I tested on the wrong branch. |
After proper update of the branch, two things for the case when 1 device is in chain remains.
|
thanks for checking, feedback addressed |
updated. waiting CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cezaraugusto , LGTM
Great job guys 😄 Let's give this a go on Nightly and then I think we're ready for an uplift back to 1.3 |
LGTM. Verified on Windows and Linux. Verified clicking Verification passed on
Verification passed on
Non critical issues found |
Modify Sync UI to allow only one device in chain
Modify Sync UI to allow only one device in chain
Close brave/brave-browser#6941
This PR also reverts a3708ba cc @AlexeyBarabash
Test Plan