-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
encapsulate rust json code in cpp #25975
Conversation
[puLL-Merge] - brave/brave-core@25975 DescriptionThis PR refactors the JSON handling in the Brave Wallet component, moving from direct use of Rust-based JSON functions to a C++ wrapper. It introduces a new ChangesChanges
Possible Issues
Security HotspotsNo significant security hotspots were identified. The changes primarily involve refactoring existing functionality rather than introducing new security-sensitive code. However, careful review of the JSON parsing and conversion functions is always recommended to ensure they handle edge cases and malformed input correctly. |
dbf9238
to
e26b358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust++
Released in v1.73.14 |
Resolves brave/brave-browser#41497
The original fix for 41497 was a workaround while we investigated the underlying issue
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: