-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Any calls to json::convert_all_numbers_to_string
or other functions from the same component are resulting in a crash
#41497
Closed
cdesouza-chromium opened this issue
Oct 8, 2024
· 1 comment
· Fixed by brave/brave-core#25898 or brave/brave-core#25975
Closed
Any calls to json::convert_all_numbers_to_string
or other functions from the same component are resulting in a crash
#41497
cdesouza-chromium opened this issue
Oct 8, 2024
· 1 comment
· Fixed by brave/brave-core#25898 or brave/brave-core#25975
Labels
dev-concern
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Windows
QA/No
release-notes/exclude
Milestone
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
For some unknown reason this PR has broken the Windows debug use of `json::convert_all_numbers_to_string` and others. Resolves brave/brave-browser#41497 This reverts commit a235817.
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves brave/brave-browser#41497 [1] #25830
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves brave/brave-browser#41497 [1] #25830
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves brave/brave-browser#41497 [1] #25830
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves brave/brave-browser#41497 [1] #25830
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2024
It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves brave/brave-browser#41497 [1] #25830
This issue is ultimately the result of using component builds, and the fact rust's stdlib doesn't properly support them. rust-lang/rust#131468 |
24 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
dev-concern
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Windows
QA/No
release-notes/exclude
This crash only happens when building on Windows with Debug configuration. Example stack:
The text was updated successfully, but these errors were encountered: