Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modify Sync UI to allow only one device in chain #4408

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Modify Sync UI to allow only one device in chain #4408

merged 1 commit into from
Jan 24, 2020

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jan 22, 2020 •
edited by bsclifton
Loading

Uplift request for #4239

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

@cezaraugusto cezaraugusto added this to the 1.3.x - Beta milestone Jan 22, 2020
@cezaraugusto cezaraugusto requested a review from a team January 22, 2020 17:47
@cezaraugusto cezaraugusto self-assigned this Jan 22, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jan 22, 2020 •
edited
Loading

Restarting. Doesn't look like this fully completed.

@cezaraugusto @bsclifton
Merge pull request #4239 from brave/ca-6941
99fab50 
Modify Sync UI to allow only one device in chain
@kjozwiak
Copy link
Member

Looks like it failed to fetch the repo on iOS as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.3/2/execution/node/195/log/. Going to restart iOS and see if that helps.

Looks like it failed to fetch the repo on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.3/2/execution/node/197/log/. Going to restart macOS and see if that helps.

Restarting Win x64 due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6941-1.3/2/execution/node/193/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Jan 23, 2020
kjozwiak
kjozwiak approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. @btlechowski also went through the PR as per #4239 (comment). @AlexeyBarabash also confirmed that brave/brave-browser#7893 was cause by #4324 and not #4239.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit b55dcd1 into 1.3.x Jan 24, 2020
@kjozwiak kjozwiak deleted the ca-6941-1.3 branch January 24, 2020 22:29
This was referenced Jan 24, 2020
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
CI/skip-android Do not run CI builds for Android feature/sync
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @kjozwiak