Fix #7608: Turn Sardine on for all wallet users (#7735)

Remove US-only restriction for Sardine
brave · Jul 14, 2023 · 849324c · 849324c
1 parent feb95c9
commit 849324c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift b/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift
@@ -217,12 +217,7 @@ class AssetDetailStore: ObservableObject {
   }
 
   @MainActor private func isBuyButtonSupported(in network: BraveWallet.NetworkInfo, for symbol: String) async -> Bool {
-    let buyOptions: [BraveWallet.OnRampProvider]
-    if Locale.preferredLanguages.first?.caseInsensitiveCompare("en-us") == .orderedSame {
-      buyOptions = [.ramp, .sardine, .transak]
-    } else {
-      buyOptions = [.ramp, .transak]
-    }
+    let buyOptions: [BraveWallet.OnRampProvider] = [.ramp, .sardine, .transak]
     self.allBuyTokensAllOptions = await blockchainRegistry.allBuyTokens(in: network, for: buyOptions)
     let buyTokens = allBuyTokensAllOptions.flatMap { $0.value }
     return buyTokens.first(where: { $0.symbol.caseInsensitiveCompare(symbol) == .orderedSame }) != nil

diff --git a/Sources/BraveWallet/Crypto/Stores/BuyTokenStore.swift b/Sources/BraveWallet/Crypto/Stores/BuyTokenStore.swift
@@ -158,12 +158,7 @@ public class BuyTokenStore: ObservableObject {
 
   @MainActor
   func updateInfo() async {
-    // check device language to determine if we support `Sardine`
-    if Locale.preferredLanguages.first?.caseInsensitiveCompare("en-us") == .orderedSame {
-      orderedSupportedBuyOptions = [.ramp, .sardine, .transak]
-    } else {
-      orderedSupportedBuyOptions = [.ramp, .transak]
-    }
+    orderedSupportedBuyOptions = [.ramp, .sardine, .transak]
 
     let coin = await walletService.selectedCoin()
     selectedNetwork = await rpcService.network(coin, origin: nil)

diff --git a/Tests/BraveWalletTests/BuyTokenStoreTest.swift b/Tests/BraveWalletTests/BuyTokenStoreTest.swift
@@ -168,11 +168,13 @@ class BuyTokenStoreTests: XCTestCase {
 
     await store.updateInfo()
 
-    XCTAssertEqual(store.orderedSupportedBuyOptions.count, 2)
+    XCTAssertEqual(store.orderedSupportedBuyOptions.count, 3)
     XCTAssertNotNil(store.orderedSupportedBuyOptions.first)
-    XCTAssertEqual(store.orderedSupportedBuyOptions.first!, .ramp)
+    XCTAssertEqual(store.orderedSupportedBuyOptions.first, .ramp)
+    XCTAssertNotNil(store.orderedSupportedBuyOptions[safe: 1])
+    XCTAssertEqual(store.orderedSupportedBuyOptions[safe: 1], .sardine)
     XCTAssertNotNil(store.orderedSupportedBuyOptions.last)
-    XCTAssertEqual(store.orderedSupportedBuyOptions.last!, .transak)
+    XCTAssertEqual(store.orderedSupportedBuyOptions.last, .transak)
   }
 
   @MainActor