Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Turn Sardine on for all wallet users #7608

Closed
StephenHeaps opened this issue Jun 16, 2023 · 1 comment · Fixed by #7735
Closed

Turn Sardine on for all wallet users #7608

StephenHeaps opened this issue Jun 16, 2023 · 1 comment · Fixed by #7735
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.57

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Jun 16, 2023 •
edited
Loading

Description:

iOS version of brave/brave-browser#30333 / brave/brave-browser#31096

Right now, Sardine is only turned on for US users. We want to turn it on for global wallet users now as well. They recently added global support for cards.

link to discussion -> https://bravesoftware.slack.com/archives/C03FP409W2X/p1683817345044179
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Jun 16, 2023
@StephenHeaps StephenHeaps self-assigned this Jul 13, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jul 13, 2023
@StephenHeaps StephenHeaps changed the title Turn on Sardine on for all wallet users Turn Sardine on for all wallet users Jul 13, 2023
@StephenHeaps StephenHeaps mentioned this issue Jul 13, 2023
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jul 14, 2023
StephenHeaps added a commit that referenced this issue Jul 14, 2023
@StephenHeaps
Fix #7608: Turn Sardine on for all wallet users (#7735)
849324c 
Remove US-only restriction for Sardine
@iccub iccub added this to the 1.57 milestone Jul 19, 2023
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 16.6 running 1.57 (23.8.23.20)

  • Verified steps from #7735
  • Verified Sardine is shown as a provider for purchase of ETH
  • Verified Sardine is shown as a provider for purchase of SOL (subject to availability in the region)
7608.MP4

@Uni-verse Uni-verse mentioned this issue Nov 11, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7608: Turn Sardine on for all wallet users (brave…
00345e0 
…/brave-ios#7735)

Remove US-only restriction for Sardine
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7608: Turn Sardine on for all wallet users brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv