Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Passcode doesn't screen update when the pin is entered #1475

Closed
srirambv opened this issue Sep 3, 2019 · 4 comments
Closed

Passcode doesn't screen update when the pin is entered #1475

srirambv opened this issue Sep 3, 2019 · 4 comments
Labels
bug Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. Epic: Privacy iOS 13 QA Pass - iPad QA Pass - iPhone X QA/Yes regression release-notes/exclude
Milestone
1.12

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2019

Description:

Passcode doesn't screen update when the pin is entered

Steps to Reproduce

  1. Clean install 1.12(19.08.30.20)
  2. Enable Pin code
  3. Screen still says Turn Pincode on

Actual result:
https://youtu.be/GeFtZrjbBxE

Expected result:
Should update the screen when passcode is entered

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12(19.08.30.20)

Device details:
iPhone XR

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.12 milestone Sep 3, 2019
@jhreis jhreis assigned iccub and unassigned iccub Sep 3, 2019
@iccub
Copy link
Contributor

iccub commented Sep 4, 2019

Doesn't happen to me on iPhone 7 iOS 12
I'm updating my iPad to iOS13 and going to recheck it

@iccub
Copy link
Contributor

iccub commented Sep 4, 2019

I can repro on iOS13

@srirambv srirambv added the iOS 13 label Sep 4, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Sep 4, 2019

added iOS 13 label to make it easy to track iOS 13 specific issues

iccub added a commit that referenced this issue Sep 4, 2019
@iccub
Fix #1475: Update passcode screen after completion.
788ca90
@iccub iccub mentioned this issue Sep 4, 2019
Merged
7 tasks
@jhreis jhreis closed this as completed in 82b0271 Sep 4, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Sep 6, 2019 •
edited by kjozwiak
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.06.21)

  • Verified on clean install pin code screen updates correctly when enabled
  • Verified on upgrade from AppStore build the pin code screen updates correctly when enabled

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.10.13):

  • Verified on clean install pin code screen updates correctly when enabled
  • Verified on upgrade from AppStore build the pin code screen updates correctly when enabled

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
@jhreis jhreis added the Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. label Jan 31, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. Epic: Privacy iOS 13 QA Pass - iPad QA Pass - iPhone X QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
4 participants
@kjozwiak @jhreis @iccub @srirambv