Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1475: Update passcode screen after completion. #1481

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Sep 4, 2019

Summary of Changes

This is caused due to how iOS 13 handles presentation. Now the modal VCs are showing as a popup, which makes the parent vc to not call viewDisappear

This pull request fixes issue #1475

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub assigned jhreis and danishjafri88 and unassigned jhreis and danishjafri88 Sep 4, 2019
@jhreis jhreis merged commit 82b0271 into development Sep 4, 2019
@jhreis jhreis deleted the bugfix/1475 branch September 4, 2019 22:47
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants