Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Multitasking window doesn't show Shields/Settings popup correctly #1477

Closed
srirambv opened this issue Sep 3, 2019 · 3 comments
Closed

Multitasking window doesn't show Shields/Settings popup correctly #1477

srirambv opened this issue Sep 3, 2019 · 3 comments
Labels
bug iOS 13 iPad-specific priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPad QA/Yes regression release-notes/exclude
Milestone
1.12

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2019

Description:

Multitasking window doesn't show Shields/Settings popup correctly

Steps to Reproduce

  1. Open any app
  2. Open brave as a multitasking app
  3. Open shields/settings

Actual result:
image

image

Expected result:
image

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.12(19.08.30.20)

Device details:
iPad

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes regression labels Sep 3, 2019
@srirambv srirambv added this to the 1.12 milestone Sep 3, 2019
iccub added a commit that referenced this issue Sep 4, 2019
@iccub
Fix #1477: Popups showing incorrectly in multitasking on iOS13.
e2c111d
@iccub iccub mentioned this issue Sep 4, 2019
Merged
7 tasks
@srirambv srirambv added the iOS 13 label Sep 4, 2019
iccub added a commit that referenced this issue Sep 4, 2019
@iccub
Fix #1477: Popups showing incorrectly in multitasking on iOS13.
ef6dded
@iccub iccub closed this as completed in 41a63e7 Sep 4, 2019
@srirambv srirambv mentioned this issue Sep 5, 2019
Closed
@kjozwiak
Copy link
Member

Verification PASSED on iPad Air 3rd Generation using iOS 13.1 running 1.12 (19.09.11.22):

IMG_0056
IMG_0054

@kjozwiak
Copy link
Member

@srirambv mind quickly checking this on your iPad to see if it's working as well?

@srirambv
Copy link
Contributor Author

Verification passed on iPad Pro with iOS 13.1 running 1.12(19.09.11.22)
Landscape:
image
image
image
image
image

Portrait:
image
image
image

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug iOS 13 iPad-specific priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPad QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
3 participants
@kjozwiak @jhreis @srirambv