Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1477: Popups showing incorrectly in multitasking on iOS13. #1480

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Sep 4, 2019

Summary of Changes

This pull request fixes issue #1477

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Check the popups on iOS 13 for both multitasking mode and not

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we change the modal presentation style from overFullScreen to overCurrentContext in the popover? Might that fix this bug?

@iccub
Copy link
Contributor Author

iccub commented Sep 4, 2019

this works @kylehickinson
Are there any drawbacks by switching to overCurrentContext ?

@kylehickinson
Copy link
Collaborator

@iccub Only thing that would change is if we were presenting the popover from a child controller. It would then take the frame of that child, but since we don't do that anywhere there's no difference from overFullScreen in this context

@iccub iccub merged commit 41a63e7 into development Sep 4, 2019
@iccub iccub deleted the bugfix/1477 branch September 4, 2019 18:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants