Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Quick search engines do not appear if <2 quick search engines enabled #3190

Closed
mrmikeface opened this issue Jan 12, 2021 · 1 comment · Fixed by #4861
Closed

Quick search engines do not appear if <2 quick search engines enabled #3190

mrmikeface opened this issue Jan 12, 2021 · 1 comment · Fixed by #4861
Assignees
@soner-yuksel
Labels
bug Epic: Search QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.35

Comments

@mrmikeface
Copy link

mrmikeface commented Jan 12, 2021 •
edited by soner-yuksel
Loading

Description:

Quick search does not appear if there only one "Quick-Search Engine" toggled on

Steps to Reproduce

  1. Turn off all but one quick search engine in search settings
  2. Open address bar

Actual result: No quick search bar appears above keyboard

Expected result: Appearance of quick search bar

Reproduces how often: Easily reproduced

Brave Version: 1.22.1 (20.12.10.23)

Device details: iPhone Xs (iOS 14.3)-->

Website problems only: Not website related
@soner-yuksel soner-yuksel self-assigned this Jan 17, 2022
@soner-yuksel soner-yuksel added this to the 1.35 milestone Jan 17, 2022
@soner-yuksel soner-yuksel mentioned this issue Jan 17, 2022
Merged
7 tasks
@soner-yuksel soner-yuksel linked a pull request Jan 17, 2022 that will close this issue
Fix #3959, #3190, #4860: Fixes related with missing Quick search engine bar - Wrong Top Section Header Paddings #4861
Merged
7 tasks
iccub pushed a commit that referenced this issue Jan 19, 2022
@soner-yuksel
Fix #3959, fix #3190, fix #4860: Wrong Top Section Header Paddings (#…
6fb37f5 
…4861)
Brandon-T pushed a commit that referenced this issue Jan 19, 2022
@soner-yuksel @Brandon-T
Fix #3959, fix #3190, fix #4860: Wrong Top Section Header Paddings (#…
a8d20d0 
…4861)
iccub pushed a commit that referenced this issue Jan 21, 2022
@soner-yuksel @iccub
Fix #3959, fix #3190, fix #4860: Wrong Top Section Header Paddings (#…
d1a962b 
…4861)
@kjozwiak
Copy link
Member

  • Verification PASSED on iPhone 12 running iOS 15.1.1 using 1.35 (22.1.24.16)
  • Verification PASSED on iPhone 11 running iOS 14.7.1 using 1.35 (22.1.24.16)
  • Verification PASSED on iPad Air (3rd Gen) running iOS 14.7.1 using 1.35 (22.1.24.16)

Verifications were completed via #3959 (comment) which also covers the case mentioned via #3190 (comment).

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@soner-yuksel soner-yuksel

Labels
bug Epic: Search QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.35
3 participants
@kjozwiak @soner-yuksel @mrmikeface