This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3959, #3190, #4860: Fixes related with missing Quick search engine bar - Wrong Top Section Header Paddings #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing top header padding problem for search and bookmark controller
soner-yuksel
requested review from
kylehickinson,
nuo-xu,
Brandon-T and
iccub
This was
linked to
issues
Jan 17, 2022
soner-yuksel
changed the title
soner-yuksel
changed the title
soner-yuksel
changed the title
iccub
approved these changes
Jan 19, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #3959 , #3190, #4860
Submitter Checklist:
NSLocalizableString()Test Plan:
Check specific Testing conditions for the issues inside the tickets
Screenshots:
#3959 Quick search engine bar is missing
#3190 Quick search engines do not appear
#4860 Wrong Top Section Header Padding in various Screens
Reviewer Checklist:
QA/(Yes|No)bug/enhancement