Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add to playlist option freezes on 3aw.com #3665

Closed
iccub opened this issue May 11, 2021 · 2 comments · Fixed by #3690
Closed

Add to playlist option freezes on 3aw.com #3665

iccub opened this issue May 11, 2021 · 2 comments · Fixed by #3690
Assignees
@Brandon-T
Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.25.1

Comments

@iccub
Copy link
Contributor

iccub commented May 11, 2021 •
edited
Loading

Description:

Reported here

Steps to Reproduce

  1. Go to https://www.3aw.com.au/brett-ratten-responds-to-max-king-critics/
  2. Scroll down to audio player, play it

Actual result:
Notice it freezed the app for few seconds

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.26 milestone May 11, 2021
@iccub
Copy link
Contributor Author

iccub commented May 11, 2021

Update, i can reproduce the crash on dev build only,
it doesn't crash on live app for me, changing the title

@iccub iccub removed the crash label May 11, 2021
@iccub iccub modified the milestones: 1.26, 1.27 May 11, 2021
@Brandon-T Brandon-T mentioned this issue May 18, 2021
Merged
7 tasks
@iccub iccub changed the title Add to playlist option freezes and crashes on 3aw.com Add to playlist option freezes on 3aw.com May 19, 2021
@iccub iccub modified the milestones: 1.27, 1.26 May 19, 2021
iccub pushed a commit that referenced this issue May 19, 2021
@Brandon-T
Fix #3665 - Performance issues with playlist (#3690)
4721454 
* Possible fix for performance issues in playlist for some users.
Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about.
In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
iccub pushed a commit that referenced this issue May 19, 2021
@Brandon-T @iccub
Fix #3665 - Performance issues with playlist (#3690)
eceb598 
* Possible fix for performance issues in playlist for some users.
Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about.
In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
iccub pushed a commit that referenced this issue May 21, 2021
@Brandon-T @iccub
Fix #3665 - Performance issues with playlist (#3690)
0e652da 
* Possible fix for performance issues in playlist for some users.
Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about.
In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
@kylehickinson kylehickinson modified the milestones: 1.26, 1.25.1 May 21, 2021
@srirambv
Copy link
Contributor

srirambv commented May 24, 2021 •
edited
Loading

Verification passed on iPhone XR with iOS 13.5 running 1.25.1(21.5.21.22)

+Verification passed on iPhone 7+ with iOS 14.5.1 running 1.25.1(21.5.21.22)

Verification passed on iPad Pro with iOS 14.5.1running 1.25.1(21.5.21.22)

@kjozwiak kjozwiak mentioned this issue May 24, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.1
Development

Successfully merging a pull request may close this issue.

Fix #3665 - Performance issues with playlist brave/brave-ios
4 participants
@kylehickinson @Brandon-T @iccub @srirambv