This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3665 - Performance issues with playlist #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
reviewed
May 18, 2021
| } | ||
|
|
||
| function $<observeDynamicElements>(node) { | ||
| /*function $<observeDynamicElements>(node) { |
There was a problem hiding this comment.
nit: can we remove the code instead of commenting it out?
iccub
suggested changes
May 19, 2021
Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about. In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
Brandon-T
force-pushed
the
bugfix/PlaylistPerformance
branch
from
e71d0a3 to
5d49d8b
Compare
iccub
approved these changes
May 19, 2021
iccub
pushed a commit
that referenced
this pull request
May 19, 2021
* Possible fix for performance issues in playlist for some users. Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about. In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
iccub
pushed a commit
that referenced
this pull request
May 21, 2021
* Possible fix for performance issues in playlist for some users. Instead of using observers or mutation observers or anything observing, we hook the exact attribute of the element we want to be notified about. In our case, this is always going to be an HTMLVideoElement and HTMLAudioElement. We can ignore HTMLSourceElement.
|
For testing:
Tested:
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
AVAsset.isPlayableto load asynchronously.This pull request fixes #3665
Submitter Checklist:
NSLocalizableString()Test Plan:
For testing:
Go to YouTube or any media site
Make sure network link conditioner is set to very very bad network
While the site is loading, keep trying to scroll the page.
if the page doesn't scroll properly or exhibits freezing, we have a problem.
If the page does scroll and load correctly, the toast will come up properly without lagging.
Page overall should be much snappier.
Tested:
I tested on YouTube, SoundCloud, Vimeo, dailymotion, twitch. Note for SoundCloud you have to press play first then attempt to scroll while it is loading.
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement