Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Solana Swap #6847

Closed
StephenHeaps opened this issue Jan 30, 2023 · 1 comment · Fixed by #6915
Closed

Solana Swap #6847

StephenHeaps opened this issue Jan 30, 2023 · 1 comment · Fixed by #6915
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.49

Comments

@StephenHeaps
Copy link
Contributor

Description:

Integrate Solana Swap into existing native swap UI using Jupiter as DEX aggregator
@StephenHeaps StephenHeaps self-assigned this Jan 30, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Jan 30, 2023
@StephenHeaps StephenHeaps mentioned this issue Feb 9, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps added this to the 1.49 milestone Feb 21, 2023
StephenHeaps added a commit that referenced this issue Feb 23, 2023
@StephenHeaps
Fix #6847, #6735: Integrate Solana Swap (#6915)
71b1bb4 
* Support parsing Solana Swap transaction for display in Tx Confirmation, Tx Details and Tx Summary rows.

* Support Solana Swap via Jupiter

* Fix default selectedToToken for when BAT is unavailable on Ethereum or USDC unavailable on Solana.

* Unit tests for fetching Solana swap price quotes, creating Solana swap transaction

* Improve performance of initial display of all Solana transactions in `TransactionConfirmationView` by displaying the known transaction details without waiting for estimated Solana transaction fee network call.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 23, 2023
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 16.3.1 running 1.49 (23.3.9.17)

  • Verified steps from #6915
  • Verified able to submit Solana Swap transaction
  • Verified transaction is listed under Solana Account Transactions
  • Encountered #7075 & #7076
6847.MP4

@srirambv srirambv mentioned this issue Mar 10, 2023
Closed
@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#6847, brave/brave-ios#6735: Integrate Solana Swap (…
8acd01e 
…brave/brave-ios#6915)

* Support parsing Solana Swap transaction for display in Tx Confirmation, Tx Details and Tx Summary rows.

* Support Solana Swap via Jupiter

* Fix default selectedToToken for when BAT is unavailable on Ethereum or USDC unavailable on Solana.

* Unit tests for fetching Solana swap price quotes, creating Solana swap transaction

* Improve performance of initial display of all Solana transactions in `TransactionConfirmationView` by displaying the known transaction details without waiting for estimated Solana transaction fee network call.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6847, #6735: Integrate Solana Swap brave/brave-ios
2 participants
@StephenHeaps @srirambv