Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Learn more on Jupiter as Dex aggregator should load the Privacy Policy link #7075

Closed
srirambv opened this issue Mar 10, 2023 · 1 comment · Fixed by #7077
Closed

Learn more on Jupiter as Dex aggregator should load the Privacy Policy link #7075

srirambv opened this issue Mar 10, 2023 · 1 comment · Fixed by #7077
Assignees
@StephenHeaps
Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.49

Comments

@srirambv
Copy link
Contributor

Description:

Learn more on Jupiter as Dex aggregator should load the Privacy Policy link

Steps to Reproduce

  1. Open Solana Swap
  2. Click on the info icon at the bottom of the screen
  3. Click on Learn more
  4. Loads https://jup.ag instead of https://docs.jup.ag/legal/privacy-policy similar to desktop

Actual result:

Jup.ag.MP4

Expected result:

Should load https://docs.jup.ag/legal/privacy-policy rather than loading https://jup.ag

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @jamesmudgett @HEagle18 @StephenHeaps
@srirambv srirambv added this to Web3 Mar 10, 2023
@srirambv srirambv mentioned this issue Mar 10, 2023
Closed
@StephenHeaps StephenHeaps self-assigned this Mar 10, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Mar 10, 2023
@StephenHeaps StephenHeaps mentioned this issue Mar 10, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Mar 10, 2023
@StephenHeaps
Fix #7075: Update swap learn more links to privacy policy (#7077)
4122ed1 
* Update 'learn more' button in swap to link directly to respective privacy policy

* Fix divide by 0 in swap price quote response
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 10, 2023
@iccub iccub added this to the 1.49 milestone Mar 21, 2023
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.49 (23.3.23.15)

  • Verified steps from #7077
  • Verified for Solana Learn more loads Privacy Policy on https://docs.jup.ag/legal/privacy-policy
  • Verified for Ethereum Learn more loads Privacy Policy on https://www.0x.org/privacy
iPhone 7+ (iOS 15.7.3) iPhone XR (iOS 16.3.1) iPad Pro (16.4 Beta 4)
7075-iPhone.7+.MP4
7075-iPhone.XR.MP4
7075-iPad.Pro.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7075: Update swap learn more links to privacy pol…
74a3936 
…icy (brave/brave-ios#7077)

* Update 'learn more' button in swap to link directly to respective privacy policy

* Fix divide by 0 in swap price quote response
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #7075: Update swap learn more links to privacy policy brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv