This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #2202: Display correct publisher disclaimer for connected wallets #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Jan 16, 2020
| @@ -156,6 +157,7 @@ internal extension Strings { | |||
| static let learnMoreCreateWallet1 = NSLocalizedString("BraveRewardsLearnMoreCreateWallet1", bundle: .rewardsUI, value: "Yes, I'm In!", comment: "") | |||
| static let learnMoreBraveAdsTitle = NSLocalizedString("BraveRewardsLearnMoreBraveAdsTitle", bundle: .rewardsUI, value: "Ads", comment: "") | |||
| static let tippingUnverifiedDisclaimer = NSLocalizedString("BraveRewardsTippingUnverifiedDisclaimer", bundle: .rewardsUI, value: "NOTE: This creator has not yet signed up to receive contributions from Brave users. Your browser will keep trying to contribute until they verify, or until 90 days have passed.", comment: "") | |||
| static let tippingNotConnectedDisclaimer = NSLocalizedString("BraveRewardsTippingUnverifiedDisclaimer", bundle: .rewardsUI, value: "NOTE: This Brave Verified Creator has not yet signed up to receive contributions from Brave users. Your browser will keep trying to contribute until they verify, or until 90 days have passed.", comment: "") | |||
|
|
||
| self.tippingView.overviewView.disclaimerView.isHidden = banner.status == .verified | ||
|
|
||
| if (state.ledger.walletBalances[.anonymous] ?? 0) > 0 || (state.ledger.walletBalances[.unblindedTokens] ?? 0) > 0 { |
There was a problem hiding this comment.
We use this in two places, maybe extract to a computed property on ledger object?
7 tasks
kylehickinson
force-pushed
the
publisher-panel-messaging
branch
from
481ef74 to
d3b90e8
Compare
iccub
approved these changes
Jan 16, 2020
|
Same test failures on CI, merging anyways |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes issue #2202
Submitter Checklist:
NSLocalizableString()Test Plan:
Panel messaging:
Where
- not verified:
This creator has not yet signed up to receive contributions from Brave users. Any tips you send will remain in your wallet until they verify.- not connected
This Brave Verified Creator has not yet configured their account to receive contributions from Brave Users. Any tips you send will remain in your wallet until they complete this process.Screenshots:
Publisher:
snow.fish, status:wallet_connectedPublisher:
github.com, status:unverifiedPublisher:
laurenwags.github.io, status:verifiedReviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement