Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Hide Rewards User Wallets unless compiler flag is used #2205

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

kylehickinson
Copy link
Collaborator

To be reverted in a future PR

For QA (cc @srirambv @kjozwiak): This just hides the button, the underlying wallet may still exist in your build, and you will need to reset rewards/delete & reinstall the build

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Verify without the compiler flag added when compiling that user wallets is not available in the build

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson
Copy link
Collaborator Author

Wait to merge until I can rebase on #2204

@kylehickinson kylehickinson modified the milestone: 1.15 Jan 16, 2020
@kylehickinson
Copy link
Collaborator Author

Failed with same test errors, merging anyways

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants