Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Hold first tab load until sheilds are ready #6302

Closed

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Nov 2, 2022

Summary of Changes

This pull request fixes #6261

Tab loading awaits the preparation of some ad block data. To achieve this I had to rework how the UI is loaded on the BVC so that the elements are loaded but only "enabled" once ABD is ready.

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba changed the title Js/6261 hold first tab load until sheilds are ready Hold first tab load until sheilds are ready Nov 2, 2022
@cuba cuba requested a review from a team November 2, 2022 18:26
@cuba cuba marked this pull request as ready for review November 2, 2022 18:26
@cuba cuba force-pushed the js/6261-hold-first-tab-load-until-sheilds-are-ready branch from 64f5f75 to 786f7f2 Compare November 5, 2022 09:51
@cuba cuba force-pushed the js/6261-hold-first-tab-load-until-sheilds-are-ready branch from 786f7f2 to 0f1ec7e Compare November 16, 2022 20:55
@cuba cuba force-pushed the js/6261-hold-first-tab-load-until-sheilds-are-ready branch from 0f1ec7e to fdce163 Compare November 17, 2022 14:15
@cuba
Copy link
Contributor Author

cuba commented Nov 17, 2022

Merged here: #6417

@cuba cuba closed this Nov 17, 2022
@cuba cuba deleted the js/6261-hold-first-tab-load-until-sheilds-are-ready branch December 7, 2022 01:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure shields are loaded before the first tab launches.
1 participant