This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 448
Ensure shields are loaded before the first tab launches. #6261
Labels
Milestone
Comments
cuba
added a commit
that referenced
this issue
Oct 28, 2022
cuba
added a commit
that referenced
this issue
Oct 28, 2022
cuba
added a commit
that referenced
this issue
Nov 2, 2022
11 tasks
cuba
added a commit
that referenced
this issue
Nov 5, 2022
cuba
added a commit
that referenced
this issue
Nov 16, 2022
cuba
added a commit
that referenced
this issue
Nov 17, 2022
cuba
added a commit
that referenced
this issue
Nov 17, 2022
cuba
added a commit
that referenced
this issue
Nov 17, 2022
This was referenced Nov 17, 2022
11 tasks
iccub
added a commit
that referenced
this issue
Nov 17, 2022
iccub
added a commit
that referenced
this issue
Nov 17, 2022
Verification completed using version iPhone 12 Pro - iOS 16.x Using STR in #6261 (comment)
Notes: Additional test notes - #6411 (comment) |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
Description:
When launching the application (after it is terminated) shields may not be applied momentarily.
Steps to Reproduce
Actual result:
Shields not applied applied:
Expected result:
Should apply shields right away (for that first tab):
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproducible
Brave Version:
1.45
Device details:
N/A
Additional Information
Caused by independently loading shields and the first tab. This is a race condition and usually the tab loads faster than the shields. Need to improve loading the shields (and block the first tab) from cache.
This is tricky because we don't want to block the app from launching the first tab (so it doesn't look slow) for the sake of loading shields
Youtube navigation doesn't solve the issue because it's a single page application. you need to refresh YouTube to solve the ads problem. Most people are not aware of this and stay and navigate YouTube which gives them ads all the time if this is the first page they go to after launching the app.
The text was updated successfully, but these errors were encountered: