Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Js/6261 add back youtube script #6409

Closed
wants to merge 6 commits into from

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Nov 17, 2022

Summary of Changes

This pull request fixes #6261 (partially)

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Install the app
  2. Go to YouTube.com right away
  3. Do you get YouTube ads?

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba
Copy link
Contributor Author

cuba commented Nov 17, 2022

Will make a standalone PR

@cuba cuba closed this Nov 17, 2022
@cuba cuba deleted the js/6261-add-back-youtube-script branch November 17, 2022 17:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure shields are loaded before the first tab launches.
1 participant