Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7075: Update swap learn more links to privacy policy #7077

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix #7075: Update swap learn more links to privacy policy #7077

merged 2 commits into from
Mar 10, 2023

Conversation

StephenHeaps
Copy link
Contributor

Summary of Changes

  • Update the 'Learn More' alert button to link the 0x/Jupiter privacy policy

This pull request fixes #7075

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Open Swap
  2. Change network to Solana Mainnet
  3. Tap i icon, then tap 'Learn More' in the alert
  4. Verify opens directly to jupiter privacy policy: https://docs.jup.ag/legal/privacy-policy
  5. Open Swap
  6. Change network to Ethereum Mainnet
  7. Tap i icon, then tap 'Learn More' in the alert
  8. Verify opens directly to 0x privacy policy: https://www.0x.org/privacy

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@StephenHeaps StephenHeaps self-assigned this Mar 10, 2023
@StephenHeaps StephenHeaps marked this pull request as ready for review March 10, 2023 15:13
@StephenHeaps StephenHeaps requested a review from a team as a code owner March 10, 2023 15:13
@StephenHeaps StephenHeaps requested a review from nuo-xu March 10, 2023 15:13
@StephenHeaps StephenHeaps added this to the 1.49 milestone Mar 10, 2023
@StephenHeaps StephenHeaps merged commit 4122ed1 into development Mar 10, 2023
@StephenHeaps StephenHeaps deleted the wallet/swap-privacy-policy branch March 10, 2023 17:30
@srirambv srirambv mentioned this pull request Mar 24, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7075: Update swap learn more links to privacy pol…
74a3936 
…icy (brave/brave-ios#7077)

* Update 'learn more' button in swap to link directly to respective privacy policy

* Fix divide by 0 in swap price quote response
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@nuo-xu nuo-xu nuo-xu approved these changes

Assignees

@StephenHeaps StephenHeaps

Labels
None yet
Projects
None yet
Milestone
1.49
Development

Successfully merging this pull request may close these issues.

Learn more on Jupiter as Dex aggregator should load the Privacy Policy link
3 participants
@StephenHeaps @kylehickinson @nuo-xu