Set stagehand env to "LOCAL" if we default to "LOCAL" #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcguire12
approved these changes
Dec 18, 2024
Merged
kamath
added a commit
that referenced
this pull request
Jan 3, 2025
Set stagehand env to "LOCAL" if we default to "LOCAL" (#320) * bug fix: set this.env to LOCAL if BROWSERBASE_API_KEY is not defined * changeset [2.0] Wrap StagehandPage and StagehandContext (#319) * [feat]: start to wrap page * ignore pnpm lock * wrap * temp * rewrite example * sample playwright * working with context * e2e pass context * rm example * uploads/downloads e2e * ci e2e * CI env * changeset * cleanup context test update extract_capacitor_info eval (#323) * use new site * prettier Only startDomDebug if it's enabled (#325) * Only startDomDebug if it's enabled * changeset --------- rebase Version Packages (#321) Reduce eval spend (#337) Remove duplicate logging and export page/context types (#344) Throw custom error if context is referenced without initialization (#353) * Throw error if context is referenced without initialization. Also remove act/extract handlers from lib/index * changeset fix(logger): enable disabling logger (#355) [fix]: Fix -types exposed to the client to match the expected contract (#358) Remove Stagehand Nav (#360) * Remove Stagehand Nav * changeset Co-Authored-By: Anirudh Kamath <github@kamath.io> Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
If the user sets env "BROWSERBASE" with no api key, we default to "LOCAL". This should modify the Stagehand object itself
test plan
tested locally with no browserbase api key and
stagehand.envwas "LOCAL"