Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Stagehand Nav #360

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Remove Stagehand Nav #360

merged 2 commits into from
Jan 2, 2025

Conversation

kamath
Copy link
Contributor

@kamath kamath commented Jan 2, 2025

why

Still shows up and serves no purpose. It also trips up Stagehand AI by clicking these elements in act

what changed

Deleted nav altogether

test plan

Ran the following script assuming debugDom: true in StagehandConfig

const stagehand = new Stagehand(StagehandConfig);
  await stagehand.init();
  const page = stagehand.page;
  await page.goto("https://www.google.com");
  await page.act({
    action: "type in 'Browserbase' and press Enter",
  });

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: 6e6b5bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kamath kamath marked this pull request as ready for review January 2, 2025 22:02
@kamath kamath merged commit 89841fc into main Jan 2, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
@kamath kamath deleted the anirudh/remove-stagehand-nav branch January 3, 2025 01:39
kamath added a commit that referenced this pull request Jan 3, 2025
Set stagehand env to "LOCAL" if we default to "LOCAL" (#320)

* bug fix: set this.env to LOCAL if BROWSERBASE_API_KEY is not defined

* changeset

[2.0] Wrap StagehandPage and StagehandContext (#319)

* [feat]: start to wrap page

* ignore pnpm lock

* wrap

* temp

* rewrite example

* sample playwright

* working with context

* e2e pass context

* rm example

* uploads/downloads e2e

* ci e2e

* CI env

* changeset

* cleanup context test

update extract_capacitor_info eval (#323)

* use new site

* prettier

Only startDomDebug if it's enabled (#325)

* Only startDomDebug if it's enabled

* changeset

---------

rebase

Version Packages (#321)

Reduce eval spend (#337)

Remove duplicate logging and export page/context types (#344)

Throw custom error if context is referenced without initialization (#353)

* Throw error if context is referenced without initialization. Also remove act/extract handlers from lib/index

* changeset

fix(logger): enable disabling logger (#355)

[fix]: Fix -types exposed to the client to match the expected contract (#358)

Remove Stagehand Nav (#360)

* Remove Stagehand Nav

* changeset

Co-Authored-By: Anirudh Kamath <github@kamath.io>
Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants