(GH-494) Support setting of baseline state for each issue

[christianbumann]

The Sarif report contains the BaselineState of an issue based on the SarifIssueReportFormatSettings.ExistingIssues information. BaseLineState Updated is not supported.

Fixes #494

[pascalberger]

@pascalberger changes done. Should I add a second property to the settings to define if the IssueComparer should be initialized with true to compare only persistent properties?

@christianbumann See my comment above, with the argument on the IssueComparer ctor it should be possible to support BaselineState.Updated.

[pascalberger]

We might also think about setting baselineGuid property: https://docs.oasis-open.org/sarif/sarif/v2.0/csprd02/sarif-v2.0-csprd02.html#_Toc10127680

[christianbumann]

We might also think about setting baselineGuid property: https://docs.oasis-open.org/sarif/sarif/v2.0/csprd02/sarif-v2.0-csprd02.html#_Toc10127680

BaselineGuid added

[christianbumann]

@pascalberger changes done. Should I add a second property to the settings to define if the IssueComparer should be initialized with true to compare only persistent properties?

@christianbumann See my comment above, with the argument on the IssueComparer ctor it should be possible to support BaselineState.Updated.

Update added

[pascalberger]

I fixed a few comment issues and made smaller changes to test cases.

I would like to have another look at the implementation to see if there is another implementation which does not require that much repeated loops through issues lists.

[christianbumann]

Looks good to me, imho on test could be improved and another test could be added.

[christianbumann]

Using the new logic is not required if no existing issues are provided. But without existing issues imho the performance loss is very very small - so this would give more security against the new logic. So go for if with the pull request 👍

[christianbumann]

Using the new logic is not required if no existing issues are provided. But without existing issues imho the performance loss is very very small - so this would give more security against the new logic. So go for if with the pull request 👍

The new logic is required to mark the issues as new… (your comment…)

[pascalberger]

Using the new logic is not required if no existing issues are provided. But without existing issues imho the performance loss is very very small - so this would give more security against the new logic. So go for if with the pull request 👍

@christianbumann BaseLineState should also be set if no existing issues are passed, if a Guid is passed. Consider a first run without any issues, and a second run with 1 issue. In this case there are no existing issues when generating the report for the second run, but BaseLineState should stil lbe New for the newly introduced issue.