Skip to content

Commit

Permalink
Merge pull request #25 from Abuelodelanada/main
Browse files Browse the repository at this point in the history
Make relation_name optional in lib, improve alert dir resolution
  • Loading branch information
Abuelodelanada authored Oct 13, 2021
2 parents 20621c6 + 29e3f76 commit 8de79af
Show file tree
Hide file tree
Showing 5 changed files with 338 additions and 92 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ The core implementation of this charm is represented by the [`LokiOperatorCharm`
`LokiOperatorCharm` responds to the following events:

- `loki_pebble_ready`: Here we set up pebble layer and start the service
- `relation_joined` In this event (Provided by the object `LokiProvider`) we set the `loki_push_api` (`http://{self.unit_ip}:{self.charm.port}/loki/api/v1/push`) so it can be used by a Consumer charm that uses the `LokiConsumer` object.
- `relation_joined` In this event (Provided by the object `LokiPushApiProvider`) we set the `loki_push_api` (`http://{self.unit_ip}:{self.charm.port}/loki/api/v1/push`) so it can be used by a Consumer charm that uses the `LokiPushApiConsumer` object.

Both clases `LokiProvider` and `LokiConsumer` are provided by the [`Loki library`](lib/charms/loki_k8s/v0/loki.py)
Both clases `LokiPushApiProvider` and `LokiPushApiConsumer` are provided by the [`Loki library`](lib/charms/loki_k8s/v0/loki.py)


## Design Choices
Expand Down
Loading

0 comments on commit 8de79af

Please # to comment.