Make relation_name optional in lib, improve alert dir resolution #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanciop
suggested changes
Oct 12, 2021
sed-i
requested changes
Oct 12, 2021
This was referenced Oct 13, 2021
Abuelodelanada
requested review from
sed-i,
mmanciop,
balbirthomas and
dstathis
sed-i
approved these changes
Oct 13, 2021
balbirthomas
approved these changes
Oct 13, 2021
|
@Abuelodelanada please clarify what addition to the metadata.yaml must take place in the charm that wants to use the library. See https://github.com/canonical/grafana-operator/blob/7f731fd7c8af6e9fff78230d014d412b8fcab7e0/lib/charms/grafana_k8s/v0/grafana_dashboard.py#L294 |
mmanciop
suggested changes
Oct 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing merge conflics in @mmanciop #17, lint and static analysis.
Align behavior of the Loki library to that of Prometheus, see canonical/prometheus-k8s-operator#135