Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md #19

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Update README.md #19

merged 8 commits into from
Dec 20, 2024

Conversation

weiiwang01
Copy link
Collaborator

Applicable spec:

Overview

Update the README of the penpot charm based on the new template for IS charms.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@weiiwang01 weiiwang01 added documentation Improvements or additions to documentation trivial labels Nov 28, 2024
@weiiwang01 weiiwang01 requested a review from a team as a code owner November 28, 2024 17:18
@weiiwang01 weiiwang01 requested a review from erinecon November 28, 2024 17:18
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README -- I think it looks great!

I approve of the changes 👍 not giving an official approval due to the changes in .trivyignore

amandahla
amandahla previously approved these changes Dec 9, 2024
@weiiwang01 weiiwang01 requested a review from erinecon December 9, 2024 18:43
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

Test coverage for 84acb9f

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     244     29     68     17    85%   101-102, 114-116, 130-131, 140-142, 152-154, 163, 170-171, 270, 289, 318, 350, 366, 372, 374, 388, 416, 435, 449, 486, 531
----------------------------------------------------------
TOTAL            244     29     68     17    85%

Static code analysis report

Run started:2024-12-16 05:34:00.502683

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1221
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit 3cee050 into main Dec 20, 2024
18 checks passed
@weiiwang01 weiiwang01 deleted the update-readme branch December 20, 2024 07:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants