generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update README.md #19
Merged
Merged
Update README.md #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
added
documentation
Improvements or additions to documentation
trivial
labels
Nov 28, 2024
weiiwang01
force-pushed
the
update-readme
branch
from
November 28, 2024 17:21
418cdd8
to
693002d
Compare
erinecon
reviewed
Nov 28, 2024
erinecon
reviewed
Nov 28, 2024
1 task
erinecon
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the README -- I think it looks great!
I approve of the changes 👍 not giving an official approval due to the changes in .trivyignore
amandahla
previously approved these changes
Dec 9, 2024
Test coverage for 84acb9f
Static code analysis report
|
varshigupta12
approved these changes
Dec 19, 2024
yanksyoon
approved these changes
Dec 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Update the README of the penpot charm based on the new template for IS charms.
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)