Refactor metadata loading to better handle missing or misplaced metad…

…ata (#439) * Refactor metadata loading * Only sort if any were loaded * Support 3.9 * Guarding a few other situations * Add two tests * Move typevar and cleanup one try/except
capitalone · Jun 13, 2024 · 92ee3ae · 92ee3ae
1 parent 0a28bc3
commit 92ee3ae
Show file tree

Hide file tree

Showing 4 changed files with 153 additions and 97 deletions.
diff --git a/rubicon_ml/client/rubicon.py b/rubicon_ml/client/rubicon.py
@@ -247,7 +247,7 @@ def get_project_as_df(self, name, df_type="pandas", group_by=None):
         return project.to_df(df_type=df_type, group_by=None)
 
     @failsafe
-    def get_or_create_project(self, name: str, **kwargs):
+    def get_or_create_project(self, name: str, **kwargs) -> Project:
         """Get or create a project.
 
         Parameters

diff --git a/rubicon_ml/domain/__init__.py b/rubicon_ml/domain/__init__.py
@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Union
+from typing import TypeVar, Union
 
 from rubicon_ml.domain import utils
 from rubicon_ml.domain.artifact import Artifact
@@ -13,6 +13,11 @@
 
 DOMAIN_TYPES = Union[Artifact, Dataframe, Experiment, Feature, Metric, Parameter, Project]
 
+DomainsVar = TypeVar(
+    "DomainsVar", Artifact, Dataframe, Experiment, Feature, Metric, Parameter, Project
+)
+
+
 __all__ = [
     "Artifact",
     "Dataframe",