Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor metadata loading to better handle missing or misplaced metadata #439

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Refactor metadata loading to better handle missing or misplaced metadata #439

merged 6 commits into from
Jun 13, 2024

Conversation

stephenpardy
Copy link
Contributor

@stephenpardy stephenpardy commented Jun 10, 2024 •
edited
Loading

What

  • Refactors the existing metadata loading mechanism to better handle different errors - logging to the user if a particular file couldn't be loaded.
  • Also refactors to better follow DRY principle.

How to Test

  • Run existing unit tests
  • Added two tests that demonstrate error handling

@stephenpardy stephenpardy marked this pull request as ready for review June 10, 2024 22:43
@stephenpardy stephenpardy requested review from a team as code owners June 10, 2024 22:43
ryanSoley
ryanSoley reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@ryanSoley ryanSoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for abstracting that block - much cleaner now! left a couple comments

@stephenpardy stephenpardy requested a review from ryanSoley June 12, 2024 19:12
@stephenpardy stephenpardy merged commit 92ee3ae into main Jun 13, 2024
7 checks passed
@stephenpardy stephenpardy deleted the metadata_error_message branch June 13, 2024 14:46
@ryanSoley ryanSoley mentioned this pull request Jun 17, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ryanSoley ryanSoley ryanSoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenpardy @ryanSoley