-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
process mini magic commands with combine_options #1754
process mini magic commands with combine_options #1754
Conversation
hey @bensie @eavgerinos, can you take a look at this when you have time? i made some changes for mini magick processings to take advantage of |
more comments .... so basically, previously we would have to do
which would generate two commands
but with this change, we would do
and it generates one command
|
Hence |
Can we get this merged @bensie? |
process mini magic commands with combine_options
Thanks @bernabas! |
@bensie no problem, thanks for the merge |
This method isn't intended to be part of the public API. It's used internally by the processor to accept `combine_options` introduced at carrierwaveuploader#1754.
Since carrierwaveuploader#1754 merge, JRuby builds fails due to the new hash syntax. See https://travis-ci.org/carrierwaveuploader/carrierwave/jobs/93603851 This is due to JRuby mode. `jruby` resolves to 1.7.10 in 1.9 mode and `jruby-head` resolves to the JRuby master branch in 2.1 mode. As Travis doesn't support d20 and d21 for JRuby (see travis-ci/travis-ci#2432 (comment)), using `JRUBY_OPTS` in the build matrix fixes the modes to run. This matches MRI Ruby minimal requirements for CarrierWave 1.0.0.
Since carrierwaveuploader#1754 merge, JRuby builds fails due to the new hash syntax. See https://travis-ci.org/carrierwaveuploader/carrierwave/jobs/93603851 This is due to JRuby mode. `jruby` resolves to 1.7.10 in 1.9 mode and `jruby-head` resolves to the JRuby master branch in 2.1 mode. As Travis doesn't support d20 and d21 for JRuby (see travis-ci/travis-ci#2432 (comment)), using `JRUBY_OPTS` sets the mode to run for JRuby 1.7. This matches MRI Ruby minimal requirements for CarrierWave 1.0.0.
This method isn't intended to be part of the public API. It's used internally by the processor to accept `combine_options` introduced at carrierwaveuploader#1754.
Since carrierwaveuploader#1754 merge, JRuby builds fails due to the new hash syntax. See https://travis-ci.org/carrierwaveuploader/carrierwave/jobs/93603851 This is due to JRuby mode. `jruby` resolves to 1.7.10 in 1.9 mode and `jruby-head` resolves to the JRuby master branch in 2.1 mode. As Travis doesn't support d20 and d21 for JRuby (see travis-ci/travis-ci#2432 (comment)), using `JRUBY_OPTS` sets the mode to run for JRuby 1.7. This matches MRI Ruby minimal requirements for CarrierWave 1.0.0.
@bernabas How can I use the combine_options to append a "+" operator (e.g. +antialias)? https://github.com/minimagick/minimagick/blob/master/lib/mini_magick/tool.rb#L163 |
No description provided.