ARCT-1740 #7
Open
ARCT-1740 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-fog-loading Improve Fog Loading
…e_refactors Small refactors on code
…refactor-specs Move to Rspec 3 syntax and update rspec version
…fix-1631 [Fix 1631] Add proper documentation for fog/aws
* Add a line clarifying that 1.0.0 is still forthcoming * Add a line clarifying how to bundle the gem so that the multiple uploader support referenced in the README is available.
Model.attached was nil, using model_attached fixes it.
…_refactor simplify logic on bool method
…adme-for-multi Clarify what's necessary for mount_uploaders
…_quotes Add missing quotes. [CI SKIP]
…hanges when assigning something blank to a mounter that was originally blank
…fix_1571 [Fix carrierwaveuploader#1571] - Do not write to ActiveModel::Dirty changes when assigning ...
Mime-types 2.6.1+ has a columnar store that only loads the data that is needed for a drastically reduced memory footprint. cc/ @jeremyevans @halostatue
…me-types Decrease Memory footprint
Remove locales from main repository
Add MIT license badge to the README
add spec: recreate_versions! should not change original file
…-download-by-url Headers for download by url
I noticed an issue when deploying to my Heroku app. ``` remote: You have added to the Gemfile: remote: * google-api-client (< 0.9, >= 0.6.2) remote: remote: You have deleted from the Gemfile: remote: * google-api-client (< 0.9, >= 0.6.2) remote: ! remote: ! Failed to install gems via Bundler. ``` Changing the order of these requirements fixed it for me.
Update README.md
…emfile Add Rails 5.0 stable gemfile for testing.
…oogle-storage-public-url Avoids a GET for Google Cloud storage public_urls
…rence_cache_dir_name_key_format Fixed bug with the difference of key format between generate_cache_id and clean_cache!
…ngs-from-specs Remove warnings from specs
|
I though @bernabas opened a PR to get the custom options into carrierwave at one point? |
|
They never merged it :(. It even had people +1 it. No bloody idea why |
|
Or maybe they did since Oct? When I was checking the. It hadn't been :( |
|
carrierwaveuploader#1754 hmm it is merged |
|
Lol, weird. Maybe it just wasn't in the 0.9 branch we used then. Either way, let me test out running WW directly off of 1.0 then! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chancedowns @wwjeff @weddingwire/code-review this will bring our repo in line with carrierwave 1.0.0, with our customizations (ability to pass specific params to chained imagick operations) mixed in
Once this is merged I'll bump the version in wwng's Gemfile.lock