Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Short flag for log space not working #567

Closed
5 tasks
dseifert opened this issue Sep 14, 2019 · 1 comment · Fixed by #610
Closed
5 tasks

Short flag for log space not working #567

dseifert opened this issue Sep 14, 2019 · 1 comment · Fixed by #610

Comments

@dseifert
Copy link

System Info

  • Operating System: Linux computer 4.15.0-62-generic #69-Ubuntu SMP Wed Sep 4 20:55:53 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
  • Python Version: Python 2.7.15+
  • Version of catkin_tools: 0.4.5
  • ROS Distro: melodic

Build / Run Issue

  • Works with catkin_make
  • Works with catkin_make_isolated --merge
  • Works with catkin build
  • Works with catkin build -p1
  • I did not read this

Expected Behavior

Running catkin config -l my-new-log-dir should configure my log directory.

Actual Behavior

Error: Unknown verb 'my-new-log-dir' provided.

Steps to Reproduce the Issue

catkin config -l my-new-log-dir

Also check

catkin config -l

which will set Additional Make Args: -l

Proposed solution

The reason why this happens is that catkin_tools/jobs/commands/make.py already defines -l. Easiest solution would be to change the log space short flag from '-l' to '-L'. If that is acceptable, I can create a pull request)
@beetleskin
Copy link

I guess catkin is dead - long live colcon?

@timonegk timonegk mentioned this issue Jun 3, 2020
Merged
mikepurvis pushed a commit that referenced this issue Jun 3, 2020
@timonegk
Cleanup of jobs flag parsing (#610)
9a3cc31 
Summary of the changes:

 * change log space location flag from -l to -L to avoid conflicts (closes #567)
 * clean up regular expressions that were not really readable and add explanatory comments to the new ones
 * add two additional small tests regarding the job flags
 * add `-l` to parser to be shown on `--help`
 * specify type of `-l`, `-j` and `-p` options for more useful error messages
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup jobs flag parsing
2 participants
@dseifert @beetleskin