Cleanup jobs flag parsing #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of the changes: * change log space location flag from -l to -L to avoid conflicts (closes #567) * clean up regular expressions that were not really readable and add explanatory comments to the new ones * add two additional small tests regarding the job flags * add `-l` to parser to be shown on `--help` * specify type of `-l`, `-j` and `-p` options for more useful error messages
|
This looks reasonable as well. Would be great to have some tests covering this, but it's a good start. |
|
Unit tests for both functions exist in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
-lto parser to be shown on--help-l,-jand-poptions for more useful error messages