Fix incorrect abort in EntryIntl_PluralRulesSelect #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuanjl
force-pushed
the
fixIntlPluralRulesAbort
branch
from
7d992aa to
d59b472
Compare
|
Thanks @rain6851 for the bug report. Thanks @sunlili for the older bug report of this issue - sorry I hadn't got to it sooner. |
rhuanjl
force-pushed
the
fixIntlPluralRulesAbort
branch
from
d59b472 to
dfeb015
Compare
|
There may be a wider piece to look at with ICU_ASSERTs they're used when getting data back from ICU - if the data isn't what is expected Abort is called; in this case the expectation was wrong - could we make non-fatal errors of some kind for other cases? SO the unexpected data is not exposed to the user but they can at least catch/debug whatever the issue is. This would be a different PR - just noting it here as something to consider. |
When rounding a number to "x significant figures" Rounding diff can be arbitrarily large There was an abort for rounding diffs > 1 invalid in many cases.
rhuanjl
force-pushed
the
fixIntlPluralRulesAbort
branch
from
dfeb015 to
95908ad
Compare
ppenzin
approved these changes
Mar 23, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rounding a number to "x significant figures", rounding diff can be arbitrarily large.
There was an ICU_ASSERT (which is actually an abort in release builds) for rounding diffs > 1 which was clearly invalid in many cases.
Assumedly this had been put in because the same code was meant to handle rounding to X decimal places which should always produce a diff < 1; but valid paths must never result in an abort - hence condition relaxed to account for rounding to significant figures.
Fix: #6633
Fix: #6639
Fix: #6640
Fix: #6475