Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(rss): map charm members to their github profiles #6

Closed
wants to merge 1 commit into from

Conversation

bashbunni
Copy link
Member

Add the team information to map blog post authors to team member's githubs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9947188563

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rss.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
rss.go 1 0.0%
Totals Coverage Status
Change from base Build 9862184938: 0.0%
Covered Lines: 0
Relevant Lines: 437

💛 - Coveralls

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this generic since we want people to use charmbracelet/markscribe as the canonical project

@bashbunni
Copy link
Member Author

@aymanbagabas what would you suggest doing instead or where else could I put this (in the template file somehow?) that would make it more generic?

@ccoVeille
Copy link

I would keep this generic since we want people to use charmbracelet/markscribe as the canonical project

I was also surprised by this addition to this package I thought to be generic and not charm based

@aymanbagabas
Copy link
Member

@aymanbagabas what would you suggest doing instead or where else could I put this (in the template file somehow?) that would make it more generic?

You could put them in the template file. With the help of go-sprout/sprig, we could map the Charm author from the RSS to their GitHub username 🙂

@bashbunni
Copy link
Member Author

@aymanbagabas Thanks for pointing me in the right direction here! I did as you said using sprout and it works great. https://github.com/charmbracelet/.github/pull/5/files#diff-885b271153664f100985178e148d28687d6220474d93e4526bf5f9e17c5263d9R11

@bashbunni bashbunni closed this Jul 16, 2024
@bashbunni bashbunni deleted the blog-authors branch July 16, 2024 23:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants