feat: runtime independent examples #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dignifiedquire
force-pushed
the
runtimes
branch
from
b8ce2cc to
db360f1
Compare
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 22, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
2 tasks
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 23, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
Simon-Laux
reviewed
Jun 23, 2022
examples/src/bin/gmail_oauth2.rs
Outdated
Comment on lines
52
to
57
| // TODO: get rid of this | ||
| let mut msgs = unsafe { std::pin::Pin::new_unchecked(&mut msgs) }; | ||
|
|
||
| while let Some(msg) = msgs.next().await { | ||
| print!("{:?}", msg?); | ||
| } |
There was a problem hiding this comment.
noob question: whats the pin needed for?
There was a problem hiding this comment.
it wasn't needed anymore :)
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 24, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
link2xt
approved these changes
Jun 24, 2022
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 27, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hard dependency on the runtime of async-std and adds examples of using tokio@0.2 and futures@0.3 runtimes.
Depends on
cc @jonhoo