Skip to content

Commit

Permalink
bugfix for #64: use isSignificant() for fullGcPause correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
XunjunYin authored and chewiebug committed Apr 23, 2013
1 parent c9e756d commit f617aad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/main/java/com/tagtraum/perf/gcviewer/ModelPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ public void setModel(GCModel model) {
true);
updateValue(localStrings.getString("data_panel_avg_fullgcpause"),
fullGCDataAvailable ? pauseFormatter.format(model.getFullGCPause().average()) + "s (\u03c3=" + pauseFormatter.format(model.getFullGCPause().standardDeviation()) +")" : "n/a",
fullGCDataAvailable ? isSignificant(model.getFullGCPause().average(), model.getPause().standardDeviation()) : false);
fullGCDataAvailable ? isSignificant(model.getFullGCPause().average(), model.getFullGCPause().standardDeviation()) : false);
updateValue(localStrings.getString("data_panel_min_max_full_gc_pause"),
fullGCDataAvailable ? pauseFormatter.format(model.getFullGCPause().getMin()) + "s / " + pauseFormatter.format(model.getFullGCPause().getMax()) + "s" : "n/a",
fullGCDataAvailable);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ private void exportPauseSummary(PrintWriter out, GCModel model) {
}

if (fullGCDataAvailable) {
exportValue(out, "avgFullGCPauseIsSig", isSignificant(model.getFullGCPause().average(), model.getPause().standardDeviation()));
exportValue(out, "avgFullGCPauseIsSig", isSignificant(model.getFullGCPause().average(), model.getFullGCPause().standardDeviation()));
exportValue(out, "avgFullGCPause", pauseFormatter.format(model.getFullGCPause().average()), "s");
exportValue(out, "avgFullGCPause\u03c3", pauseFormatter.format(model.getFullGCPause().standardDeviation()), "s");
}
Expand Down

0 comments on commit f617aad

Please # to comment.