SummaryDataWriter.java: uncorrectly using isSignificant() for fullGCPause @line213?

[XunjunYin]

hi,

I wonder whether the following is the correct way using isSignificant() method:
213: exportValue(out, "avgFullGCPauseIsSig", isSignificant(model.getFullGCPause().average(), model.getFullGCPause().standardDeviation()));

my version is 1.32

212: if (fullGCDataAvailable) {
213: exportValue(out, "avgFullGCPauseIsSig", isSignificant(model.getFullGCPause().average(), model.getPause().standardDeviation()));
214: exportValue(out, "avgFullGCPause", pauseFormatter.format(model.getFullGCPause().average()), "s");
215: exportValue(out, "avgFullGCPause\u03c3", pauseFormatter.format(model.getFullGCPause().standardDeviation()), "s");
216: }
217: else {
218: exportValue(out, "avgFullGCPause", "n.a.", "s");
219: }

regards
elsewhere-

[chewiebug]

Hi,

You sure are right that this is not correct!

I would like to set you as the author of this contribution, in order to make it show up in your github profile. I need the email address that is linked to your github account to be able to it. Please send it to gcviewer@gmx.ch.

Regards, Jörg

[chewiebug]

Hi,

I have committed your fix, thank you very much for your contribution!

Regards, Jörg