Fix PNG file from current graph is not loading the actual GUI configurations #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted View properties for the current chart, the application reloads the definitions found on gcviewer.properties. This small fix corrects this behaviour, capturing the current view configurations for the chart (E.g. if a specific GC line is visible or not) while exporting a PNG file.
|
@chewiebug Please let me know if you have any concerns with merging this PR. The first check on travis-ci seems to be breaking by a configuration issue. It looks like the build environment changed since the last working build. I cannot view the results from Better Code Hub to understand if there is something I should fix in my implementation. Thanks |
|
Hi Sandro
It looks indeed, like oraclejdk8 is not supported on travis-ci any more.
I'll take a look.
Best regards,
Jörg
|
|
Hi Sandro I have fixed the travis build, rebased your commit on top of the fixed develop branch and added your name to the list of contributors. Thank you very much for your contribution! Best regards, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thanks very much for maintaining this project!
I have found this unexpected behaviour while exporting PNG graphics from the current graph.
When a chart is exported as a PNG file, instead of applying the selected View properties for the current chart, the application reloads the definitions found on gcviewer.properties.
This small fix corrects this behaviour, capturing the current view configurations for the chart (E.g. if a specific GC line is visible or not) while exporting a PNG file.