Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/#129/fix png export to use current configuration #229

Merged

Conversation

chewiebug
Copy link
Owner

No description provided.

Sandro Rossi and others added 2 commits September 14, 2019 17:50
…ted View properties for the current chart, the application reloads the definitions found on gcviewer.properties.

This small fix corrects this behaviour, capturing the current view configurations for the chart (E.g. if a specific GC line is visible or not) while exporting a PNG file.
@chewiebug
Copy link
Owner Author

-> closes #227 + #129

@chewiebug chewiebug merged commit 695f8f4 into develop Sep 14, 2019
@chewiebug chewiebug deleted the feature/#129/fix-png-export-to-use-current-configuration branch September 14, 2019 16:23
@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #229 into develop will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #229      +/-   ##
============================================
- Coverage      70.22%   70.2%   -0.03%     
- Complexity      1515    1516       +1     
============================================
  Files            145     145              
  Lines           8522    8531       +9     
  Branches        1355    1388      +33     
============================================
+ Hits            5985    5989       +4     
- Misses          1954    1958       +4     
- Partials         583     584       +1
Impacted Files Coverage Δ Complexity Δ
...a/com/tagtraum/perf/gcviewer/view/AboutDialog.java 84.28% <ø> (ø) 5 <0> (ø) ⬇️
...com/tagtraum/perf/gcviewer/ctrl/action/Export.java 47.76% <0%> (-1.47%) 2 <0> (ø)
...raum/perf/gcviewer/exp/impl/DataWriterFactory.java 27.27% <0%> (ø) 2 <0> (ø) ⬇️
...tagtraum/perf/gcviewer/exp/impl/PNGDataWriter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...gtraum/perf/gcviewer/view/SimpleChartRenderer.java 84% <100%> (+0.66%) 4 <0> (+1) ⬆️
...java/com/tagtraum/perf/gcviewer/model/GCModel.java 86.58% <0%> (-0.22%) 139% <0%> (ø)
...gtraum/perf/gcviewer/ctrl/impl/GcSeriesLoader.java 83.14% <0%> (+2.24%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc21c8f...236c90b. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants