Fix quitting on macOS #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QuitHandler that proxies our Exit action needs to call
the performQuit() method on the QuitResponse that it receives.
See the Javadoc for com.apple.eawt.QuitHandler.handleQuitRequestWith()
which says:
/**
* Invoked when the application is asked to quit.
*
* Implementors must call either {@link QuitResponse#cancelQuit()}, {@link QuitResponse#performQuit()}, or ensure the application terminates.
* The process (or log-out) requesting this app to quit will be blocked until the {@link QuitResponse} is handled.
...
Fixes chewiebug#247
chewiebug
added a commit
that referenced
this pull request
Oct 24, 2020
|
Thank you very much for your contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QuitHandlerthat proxies ourExitaction needs to call theperformQuit()method on theQuitResponsethat it receives.See the Javadoc for
com.apple.eawt.QuitHandler.handleQuitRequestWith()which says:Fixes #247