Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix quitting on macOS #248

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Commits on Oct 15, 2020

  1. Fix quitting on macOS

    The QuitHandler that proxies our Exit action needs to call
    the performQuit() method on the QuitResponse that it receives.
    See the Javadoc for com.apple.eawt.QuitHandler.handleQuitRequestWith()
    which says:
    
      /**
       * Invoked when the application is asked to quit.
       *
       * Implementors must call either {@link QuitResponse#cancelQuit()}, {@link QuitResponse#performQuit()}, or ensure the application terminates.
       * The process (or log-out) requesting this app to quit will be blocked until the {@link QuitResponse} is handled.
       ...
    
    Fixes chewiebug#247
    jkaving committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    13bd07c View commit details
    Browse the repository at this point in the history