You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On make install, a very large amount of headers is exported. This makes it impossible for internal refactorings to ever be possible as we've spilled all the implementation details externally, and Hyrum's law will make it impossible to change.
We have a single header that should specify the API for Surelog: Surelog/API/Surelog.h. However, now there are many headers that with there mere existence in an installation all give the impression to provide a stable API. We should strive to provide any user-visible stuff only in there or have a very limited set of includes that we actually export and are comfortable to keep stable long-term.
There is a kitchen-sink include that is exported (Surelog/surelog.h) which should only include the limited set of files we need to export (and eventually, we should eliminate this header as it is hard to reason what the users will actually use. IWYU!).
I suggest the following steps
figure out what actually needs to be visible (I suspect something like error reporting, symbolId, PathId, symbol table, command line parser, maybe a few more)
Look through these headers and make sure they don't accidentally rely on other things. Possibly cleanup.
Add a #warning in the surelog. h header to encourage people to include what they need (IWYU).
In a first step, reduce the amount of things included in surelog.h as determined in 1 and possibly user feedback.
reduce the number of header exported in an make install to the relevant ones and pledge to keep them backward compatible long-term
The text was updated successfully, but these errors were encountered:
hzeller
added a commit
to hzeller/Surelog
that referenced
this issue
Apr 6, 2023
It makes it hard to reason which actual dependencies
are used. Being specific here allows us to narrow
down the APIs that we actually would like to make
public and provide long-term.
Issues: chipsalliance#3568
Signed-off-by: Henner Zeller <h.zeller@acm.org>
The kitchen-sink include file Surelog/surelog.h makes things
look simple, but it also hides what we actually want.
So apply IWYU principle and only include what we need.
This will help us long-term to tackle
chipsalliance/Surelog#3568
Signed-off-by: Henner Zeller <h.zeller@acm.org>
On
make install
, a very large amount of headers is exported. This makes it impossible for internal refactorings to ever be possible as we've spilled all the implementation details externally, and Hyrum's law will make it impossible to change.We have a single header that should specify the API for Surelog:
Surelog/API/Surelog.h
. However, now there are many headers that with there mere existence in an installation all give the impression to provide a stable API. We should strive to provide any user-visible stuff only in there or have a very limited set of includes that we actually export and are comfortable to keep stable long-term.There is a kitchen-sink include that is exported (Surelog/surelog.h) which should only include the limited set of files we need to export (and eventually, we should eliminate this header as it is hard to reason what the users will actually use. IWYU!).
I suggest the following steps
#warning
in the surelog. h header to encourage people to include what they need (IWYU).make install
to the relevant ones and pledge to keep them backward compatible long-termThe text was updated successfully, but these errors were encountered: